Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min transfer amounts per network #474

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

harisang
Copy link
Contributor

@harisang harisang commented Dec 24, 2024

This PR sets min transfer amounts (native token and COW) for all networks, and removes the runtime arg for determining those as it has been rarely (if ever) used in the past.

@harisang harisang requested a review from fhenneke December 24, 2024 14:39
src/fetch/transfer_file.py Outdated Show resolved Hide resolved
src/config.py Outdated Show resolved Hide resolved
@harisang harisang requested a review from fhenneke January 8, 2025 07:36
@harisang harisang changed the title Add default min transfer amounts per network Add min transfer amounts per network Jan 8, 2025
Copy link
Collaborator

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We need a corresponding PR to data-jobs to not pass those old arguments anymore.

@harisang
Copy link
Contributor Author

harisang commented Jan 8, 2025

Looks good to me.

We need a corresponding PR to data-jobs to not pass those old arguments anymore.

The new jobs were actually set up without these arguments so no need for a PR there. See:

@harisang harisang merged commit a4e55bd into main Jan 8, 2025
6 checks passed
@harisang harisang deleted the extend_default_min_transfers_to_all_networks branch January 8, 2025 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants